net: usb: smsc95xx: Fix an error code in smsc95xx_reset()

Dan Carpenter · kuba-moo · commit c53647a5df9e · 2023-10-17T17:53:36.000-07:00
Return a negative error code instead of success. Fixes: 2f7ca80 ("net: Add SMSC LAN9500 USB2.0 10/100 ethernet adapter driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Link: https://lore.kernel.org/r/147927f0-9ada-45cc-81ff-75a19dd30b76@moroto.mountain Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
@@ -897,7 +897,7 @@ static int smsc95xx_reset(struct usbnet *dev)
 
 	if (timeout >= 100) {
 		netdev_warn(dev->net, "timeout waiting for completion of Lite Reset\n");
-		return ret;
+		return -ETIMEDOUT;
 	}
 
 	ret = smsc95xx_set_mac_address(dev);

Original file line number	Diff line number	Diff line change
`@@ -897,7 +897,7 @@ static int smsc95xx_reset(struct usbnet *dev)`
`897`	`897`
`898`	`898`	`if (timeout >= 100) {`
`899`	`899`	`netdev_warn(dev->net, "timeout waiting for completion of Lite Reset\n");`
`900`		`- return ret;`
	`900`	`+ return -ETIMEDOUT;`
`901`	`901`	`}`
`902`	`902`
`903`	`903`	`ret = smsc95xx_set_mac_address(dev);`