NFS: set varaiable nfs_netfs_debug_id storage-class-specifier to static

Tom Rix · amschuma-ntap · commit c5733ae6dc89 · 2023-04-21T16:36:21.000-04:00
smatch reports
fs/nfs/fscache.c:260:10: warning: symbol
  'nfs_netfs_debug_id' was not declared. Should it be static?

This variable is only used in its defining file, so it should be static

Signed-off-by: Tom Rix &lt;trix@redhat.com&gt;
Signed-off-by: Anna Schumaker &lt;Anna.Schumaker@Netapp.com&gt;
diff --git a/fs/nfs/fscache.c b/fs/nfs/fscache.c
@@ -257,7 +257,7 @@ int nfs_netfs_readahead(struct readahead_control *ractl)
 	return 0;
 }
 
-atomic_t nfs_netfs_debug_id;
+static atomic_t nfs_netfs_debug_id;
 static int nfs_netfs_init_request(struct netfs_io_request *rreq, struct file *file)
 {
 	rreq->netfs_priv = get_nfs_open_context(nfs_file_open_context(file));

Original file line number	Diff line number	Diff line change
`@@ -257,7 +257,7 @@ int nfs_netfs_readahead(struct readahead_control *ractl)`
`257`	`257`	`return 0;`
`258`	`258`	`}`
`259`	`259`
`260`		`-atomic_t nfs_netfs_debug_id;`
	`260`	`+static atomic_t nfs_netfs_debug_id;`
`261`	`261`	`static int nfs_netfs_init_request(struct netfs_io_request rreq, struct file file)`
`262`	`262`	`{`
`263`	`263`	`rreq->netfs_priv = get_nfs_open_context(nfs_file_open_context(file));`