Skip to content

Commit c60bd96

Browse files
anderssonwsakernel
authored andcommitted
i2c: qcom-geni: Use dev_err_probe() for GPI DMA error
The GPI DMA engine driver can be compiled as a module, in which case the likely probe deferral "error" shows up in the kernel log. Switch to using dev_err_probe() to silence this warning and to ensure that "devices_deferred" in debugfs carries this information. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Reviewed-by: Vinod Koul <vkoul@kernel.org> Signed-off-by: Wolfram Sang <wsa@kernel.org>
1 parent 39c0257 commit c60bd96

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/i2c/busses/i2c-qcom-geni.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -843,10 +843,8 @@ static int geni_i2c_probe(struct platform_device *pdev)
843843
/* FIFO is disabled, so we can only use GPI DMA */
844844
gi2c->gpi_mode = true;
845845
ret = setup_gpi_dma(gi2c);
846-
if (ret) {
847-
dev_err(dev, "Failed to setup GPI DMA mode:%d ret\n", ret);
848-
return ret;
849-
}
846+
if (ret)
847+
return dev_err_probe(dev, ret, "Failed to setup GPI DMA mode\n");
850848

851849
dev_dbg(dev, "Using GPI DMA mode for I2C\n");
852850
} else {

0 commit comments

Comments
 (0)