Skip to content

Commit c683651

Browse files
flukejonesij-intel
authored andcommitted
platform/x86: asus-wmi: deprecate bios features
With the existence of the asus-armoury module the attributes no longer need to live under the /sys/devices/platform/asus-nb-wmi/ path. Deprecate all those that were implemented in asus-bioscfg with the goal of removing them fully in the next LTS cycle. Signed-off-by: Denis Benato <denis.benato@linux.dev> Signed-off-by: Luke D. Jones <luke@ljones.dev> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> Link: https://patch.msgid.link/20251102215319.3126879-8-denis.benato@linux.dev Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
1 parent 7725a2d commit c683651

3 files changed

Lines changed: 124 additions & 25 deletions

File tree

Documentation/ABI/testing/sysfs-platform-asus-wmi

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ Date: Aug 2022
6363
KernelVersion: 6.1
6464
Contact: "Luke Jones" <luke@ljones.dev>
6565
Description:
66+
DEPRECATED, WILL BE REMOVED SOON: please use asus-armoury
6667
Switch the GPU hardware MUX mode. Laptops with this feature can
6768
can be toggled to boot with only the dGPU (discrete mode) or in
6869
standard Optimus/Hybrid mode. On switch a reboot is required:
@@ -75,6 +76,7 @@ Date: Aug 2022
7576
KernelVersion: 5.17
7677
Contact: "Luke Jones" <luke@ljones.dev>
7778
Description:
79+
DEPRECATED, WILL BE REMOVED SOON: please use asus-armoury
7880
Disable discrete GPU:
7981
* 0 - Enable dGPU,
8082
* 1 - Disable dGPU
@@ -84,6 +86,7 @@ Date: Aug 2022
8486
KernelVersion: 5.17
8587
Contact: "Luke Jones" <luke@ljones.dev>
8688
Description:
89+
DEPRECATED, WILL BE REMOVED SOON: please use asus-armoury
8790
Enable the external GPU paired with ROG X-Flow laptops.
8891
Toggling this setting will also trigger ACPI to disable the dGPU:
8992

@@ -95,6 +98,7 @@ Date: Aug 2022
9598
KernelVersion: 5.17
9699
Contact: "Luke Jones" <luke@ljones.dev>
97100
Description:
101+
DEPRECATED, WILL BE REMOVED SOON: please use asus-armoury
98102
Enable an LCD response-time boost to reduce or remove ghosting:
99103
* 0 - Disable,
100104
* 1 - Enable
@@ -104,6 +108,7 @@ Date: Jun 2023
104108
KernelVersion: 6.5
105109
Contact: "Luke Jones" <luke@ljones.dev>
106110
Description:
111+
DEPRECATED, WILL BE REMOVED SOON: please use asus-armoury
107112
Get the current charging mode being used:
108113
* 1 - Barrel connected charger,
109114
* 2 - USB-C charging
@@ -114,6 +119,7 @@ Date: Jun 2023
114119
KernelVersion: 6.5
115120
Contact: "Luke Jones" <luke@ljones.dev>
116121
Description:
122+
DEPRECATED, WILL BE REMOVED SOON: please use asus-armoury
117123
Show if the egpu (XG Mobile) is correctly connected:
118124
* 0 - False,
119125
* 1 - True
@@ -123,6 +129,7 @@ Date: Jun 2023
123129
KernelVersion: 6.5
124130
Contact: "Luke Jones" <luke@ljones.dev>
125131
Description:
132+
DEPRECATED, WILL BE REMOVED SOON: please use asus-armoury
126133
Change the mini-LED mode:
127134
* 0 - Single-zone,
128135
* 1 - Multi-zone
@@ -133,13 +140,15 @@ Date: Apr 2024
133140
KernelVersion: 6.10
134141
Contact: "Luke Jones" <luke@ljones.dev>
135142
Description:
143+
DEPRECATED, WILL BE REMOVED SOON: please use asus-armoury
136144
List the available mini-led modes.
137145

138146
What: /sys/devices/platform/<platform>/ppt_pl1_spl
139147
Date: Jun 2023
140148
KernelVersion: 6.5
141149
Contact: "Luke Jones" <luke@ljones.dev>
142150
Description:
151+
DEPRECATED, WILL BE REMOVED SOON: please use asus-armoury
143152
Set the Package Power Target total of CPU: PL1 on Intel, SPL on AMD.
144153
Shown on Intel+Nvidia or AMD+Nvidia based systems:
145154

@@ -150,6 +159,7 @@ Date: Jun 2023
150159
KernelVersion: 6.5
151160
Contact: "Luke Jones" <luke@ljones.dev>
152161
Description:
162+
DEPRECATED, WILL BE REMOVED SOON: please use asus-armoury
153163
Set the Slow Package Power Tracking Limit of CPU: PL2 on Intel, SPPT,
154164
on AMD. Shown on Intel+Nvidia or AMD+Nvidia based systems:
155165

@@ -160,6 +170,7 @@ Date: Jun 2023
160170
KernelVersion: 6.5
161171
Contact: "Luke Jones" <luke@ljones.dev>
162172
Description:
173+
DEPRECATED, WILL BE REMOVED SOON: please use asus-armoury
163174
Set the Fast Package Power Tracking Limit of CPU. AMD+Nvidia only:
164175
* min=5, max=250
165176

@@ -168,6 +179,7 @@ Date: Jun 2023
168179
KernelVersion: 6.5
169180
Contact: "Luke Jones" <luke@ljones.dev>
170181
Description:
182+
DEPRECATED, WILL BE REMOVED SOON: please use asus-armoury
171183
Set the APU SPPT limit. Shown on full AMD systems only:
172184
* min=5, max=130
173185

@@ -176,6 +188,7 @@ Date: Jun 2023
176188
KernelVersion: 6.5
177189
Contact: "Luke Jones" <luke@ljones.dev>
178190
Description:
191+
DEPRECATED, WILL BE REMOVED SOON: please use asus-armoury
179192
Set the platform SPPT limit. Shown on full AMD systems only:
180193
* min=5, max=130
181194

@@ -184,6 +197,7 @@ Date: Jun 2023
184197
KernelVersion: 6.5
185198
Contact: "Luke Jones" <luke@ljones.dev>
186199
Description:
200+
DEPRECATED, WILL BE REMOVED SOON: please use asus-armoury
187201
Set the dynamic boost limit of the Nvidia dGPU:
188202
* min=5, max=25
189203

@@ -192,6 +206,7 @@ Date: Jun 2023
192206
KernelVersion: 6.5
193207
Contact: "Luke Jones" <luke@ljones.dev>
194208
Description:
209+
DEPRECATED, WILL BE REMOVED SOON: please use asus-armoury
195210
Set the target temperature limit of the Nvidia dGPU:
196211
* min=75, max=87
197212

@@ -200,6 +215,7 @@ Date: Apr 2024
200215
KernelVersion: 6.10
201216
Contact: "Luke Jones" <luke@ljones.dev>
202217
Description:
218+
DEPRECATED, WILL BE REMOVED SOON: please use asus-armoury
203219
Set if the BIOS POST sound is played on boot.
204220
* 0 - False,
205221
* 1 - True
@@ -209,6 +225,7 @@ Date: Apr 2024
209225
KernelVersion: 6.10
210226
Contact: "Luke Jones" <luke@ljones.dev>
211227
Description:
228+
DEPRECATED, WILL BE REMOVED SOON: please use asus-armoury
212229
Set if the MCU can go in to low-power mode on system sleep
213230
* 0 - False,
214231
* 1 - True

drivers/platform/x86/Kconfig

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -298,6 +298,17 @@ config ASUS_WMI
298298
To compile this driver as a module, choose M here: the module will
299299
be called asus-wmi.
300300

301+
config ASUS_WMI_DEPRECATED_ATTRS
302+
bool "BIOS option support in WMI platform (DEPRECATED)"
303+
depends on ASUS_WMI
304+
default y
305+
help
306+
Say Y to expose the configurable BIOS options through the asus-wmi
307+
driver.
308+
309+
This can be used with or without the asus-armoury driver which
310+
has the same attributes, but more, and better features.
311+
301312
config ASUS_NB_WMI
302313
tristate "Asus Notebook WMI Driver"
303314
depends on ASUS_WMI

0 commit comments

Comments
 (0)