Skip to content

Commit c7c6570

Browse files
Dan Carpenterkrzk
authored andcommitted
memory: tegra: Delete dead debugfs checking code
The debugfs_create_dir() function does not return NULL, it returns error pointers. But in normal situations like this where the caller is not dereferencing "emc->debugfs.root" then we are not supposed to check the return. So instead of fixing these checks, we should delete them. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/YMCQDTSyG8UuQoh0@mwanda Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
1 parent 393d66f commit c7c6570

4 files changed

Lines changed: 0 additions & 16 deletions

File tree

drivers/memory/tegra/tegra124-emc.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1269,10 +1269,6 @@ static void emc_debugfs_init(struct device *dev, struct tegra_emc *emc)
12691269
}
12701270

12711271
emc->debugfs.root = debugfs_create_dir("emc", NULL);
1272-
if (!emc->debugfs.root) {
1273-
dev_err(dev, "failed to create debugfs directory\n");
1274-
return;
1275-
}
12761272

12771273
debugfs_create_file("available_rates", 0444, emc->debugfs.root, emc,
12781274
&tegra_emc_debug_available_rates_fops);

drivers/memory/tegra/tegra20-emc.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -776,10 +776,6 @@ static void tegra_emc_debugfs_init(struct tegra_emc *emc)
776776
}
777777

778778
emc->debugfs.root = debugfs_create_dir("emc", NULL);
779-
if (!emc->debugfs.root) {
780-
dev_err(emc->dev, "failed to create debugfs directory\n");
781-
return;
782-
}
783779

784780
debugfs_create_file("available_rates", 0444, emc->debugfs.root,
785781
emc, &tegra_emc_debug_available_rates_fops);

drivers/memory/tegra/tegra210-emc-core.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1759,10 +1759,6 @@ static void tegra210_emc_debugfs_init(struct tegra210_emc *emc)
17591759
}
17601760

17611761
emc->debugfs.root = debugfs_create_dir("emc", NULL);
1762-
if (!emc->debugfs.root) {
1763-
dev_err(dev, "failed to create debugfs directory\n");
1764-
return;
1765-
}
17661762

17671763
debugfs_create_file("available_rates", 0444, emc->debugfs.root, emc,
17681764
&tegra210_emc_debug_available_rates_fops);

drivers/memory/tegra/tegra30-emc.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1354,10 +1354,6 @@ static void tegra_emc_debugfs_init(struct tegra_emc *emc)
13541354
}
13551355

13561356
emc->debugfs.root = debugfs_create_dir("emc", NULL);
1357-
if (!emc->debugfs.root) {
1358-
dev_err(emc->dev, "failed to create debugfs directory\n");
1359-
return;
1360-
}
13611357

13621358
debugfs_create_file("available_rates", 0444, emc->debugfs.root,
13631359
emc, &tegra_emc_debug_available_rates_fops);

0 commit comments

Comments
 (0)