Skip to content

Commit c7d54da

Browse files
Kuppuswamy Sathyanarayananrafaeljw
authored andcommitted
powercap: intel_rapl_tpmi: Remove FW_BUG from invalid version check
On partitioned systems, multiple TPMI instances may exist per package, but RAPL registers are only valid on one instance since RAPL has package-scope control. Other instances return invalid versions during domain parsing, which is expected behavior on such systems. Currently this generates a firmware bug warning: intel_rapl_tpmi: [Firmware Bug]: Invalid version Remove the FW_BUG tag, downgrade to pr_debug(), and update the message to clarify that invalid versions are expected on partitioned systems where only one instance can be valid. Fixes: 9eef7f9 ("powercap: intel_rapl: Introduce RAPL TPMI interface driver") Reported-by: Zhang Rui <rui.zhang@intel.com> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Link: https://patch.msgid.link/20260211223401.1575776-1-sathyanarayanan.kuppuswamy@linux.intel.com Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 525e006 commit c7d54da

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/powercap/intel_rapl_tpmi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ static int parse_one_domain(struct tpmi_rapl_package *trp, u32 offset)
157157
tpmi_domain_flags = tpmi_domain_header >> 32 & 0xffff;
158158

159159
if (tpmi_domain_version == TPMI_VERSION_INVALID) {
160-
pr_warn(FW_BUG "Invalid version\n");
160+
pr_debug("Invalid version, other instances may be valid\n");
161161
return -ENODEV;
162162
}
163163

0 commit comments

Comments
 (0)