Skip to content

Commit c8161e5

Browse files
liux2085ingomolnar
authored andcommitted
x86/fpu: Fix FPU state core dump truncation on CPUs with no extended xfeatures
Zero can be a valid value of num_records. For example, on Intel Atom x6425RE, only x87 and SSE are supported (features 0, 1), and fpu_user_cfg.max_features is 3. The for_each_extended_xfeature() loop only iterates feature 2, which is not enabled, so num_records = 0. This is valid and should not cause core dump failure. The issue is that dump_xsave_layout_desc() returns 0 for both genuine errors (dump_emit() failure) and valid cases (no extended features). Use negative return values for errors and only abort on genuine failures. Fixes: ba38677 ("x86/elf: Add a new FPU buffer layout info to x86 core files") Signed-off-by: Yongxin Liu <yongxin.liu@windriver.com> Signed-off-by: Ingo Molnar <mingo@kernel.org> Link: https://patch.msgid.link/20251210000219.4094353-2-yongxin.liu@windriver.com
1 parent 5288176 commit c8161e5

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

arch/x86/kernel/fpu/xstate.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1946,7 +1946,7 @@ static int dump_xsave_layout_desc(struct coredump_params *cprm)
19461946
};
19471947

19481948
if (!dump_emit(cprm, &xc, sizeof(xc)))
1949-
return 0;
1949+
return -1;
19501950

19511951
num_records++;
19521952
}
@@ -1984,7 +1984,7 @@ int elf_coredump_extra_notes_write(struct coredump_params *cprm)
19841984
return 1;
19851985

19861986
num_records = dump_xsave_layout_desc(cprm);
1987-
if (!num_records)
1987+
if (num_records < 0)
19881988
return 1;
19891989

19901990
/* Total size should be equal to the number of records */

0 commit comments

Comments
 (0)