Skip to content

Commit c816ba1

Browse files
arndbbp3tk0v
authored andcommitted
EDAC/amd64: Avoid a -Wformat-security warning
Using a variable as a format string causes a (default-disabled) warning: drivers/edac/amd64_edac.c: In function 'per_family_init': drivers/edac/amd64_edac.c:3914:17: error: format not a string literal and no format arguments [-Werror=format-security] 3914 | scnprintf(pvt->ctl_name, sizeof(pvt->ctl_name), tmp_name); | ^~~~~~~~~ The code here is safe, but in order to enable the warning by default in the future, change this instance to pass the name indirectly. Fixes: e9abd99 ("EDAC/amd64: Generate ctl_name string at runtime") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Reviewed-by: Avadhut Naik <avadhut.naik@amd.com> Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com> Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com> Link: https://patch.msgid.link/20251204100231.1034557-1-arnd@kernel.org
1 parent 8f0b4cc commit c816ba1

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/edac/amd64_edac.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3911,7 +3911,7 @@ static int per_family_init(struct amd64_pvt *pvt)
39113911
}
39123912

39133913
if (tmp_name)
3914-
scnprintf(pvt->ctl_name, sizeof(pvt->ctl_name), tmp_name);
3914+
scnprintf(pvt->ctl_name, sizeof(pvt->ctl_name), "%s", tmp_name);
39153915
else
39163916
scnprintf(pvt->ctl_name, sizeof(pvt->ctl_name), "F%02Xh_M%02Xh",
39173917
pvt->fam, pvt->model);

0 commit comments

Comments
 (0)