Skip to content

Commit c841ecd

Browse files
committed
cxl/hdm: Add more HDM decoder debug messages at startup
A recent debug session yielded a couple debug messages that were useful for determining the reason why the driver was or was not falling back to CXL range register emulation, and for identifying decoder setting enumeration problems. Reviewed-by: Dave Jiang <dave.jiang@intel.com> Reviewed-by: Alison Schofield <alison.schofield@intel.com> Link: https://lore.kernel.org/r/168149845668.792294.11814353796371419167.stgit@dwillia2-xfh.jf.intel.com Signed-off-by: Dan Williams <dan.j.williams@intel.com>
1 parent 7bba261 commit c841ecd

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

drivers/cxl/core/hdm.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,14 @@ static bool should_emulate_decoders(struct cxl_endpoint_dvsec_info *info)
130130
*/
131131
for (i = 0; i < cxlhdm->decoder_count; i++) {
132132
ctrl = readl(hdm + CXL_HDM_DECODER0_CTRL_OFFSET(i));
133+
dev_dbg(&info->port->dev,
134+
"decoder%d.%d: committed: %ld base: %#x_%.8x size: %#x_%.8x\n",
135+
info->port->id, i,
136+
FIELD_GET(CXL_HDM_DECODER0_CTRL_COMMITTED, ctrl),
137+
readl(hdm + CXL_HDM_DECODER0_BASE_HIGH_OFFSET(i)),
138+
readl(hdm + CXL_HDM_DECODER0_BASE_LOW_OFFSET(i)),
139+
readl(hdm + CXL_HDM_DECODER0_SIZE_HIGH_OFFSET(i)),
140+
readl(hdm + CXL_HDM_DECODER0_SIZE_LOW_OFFSET(i)));
133141
if (FIELD_GET(CXL_HDM_DECODER0_CTRL_COMMITTED, ctrl))
134142
return false;
135143
}
@@ -868,6 +876,10 @@ static int init_hdm_decoder(struct cxl_port *port, struct cxl_decoder *cxld,
868876
if (rc)
869877
return rc;
870878

879+
dev_dbg(&port->dev, "decoder%d.%d: range: %#llx-%#llx iw: %d ig: %d\n",
880+
port->id, cxld->id, cxld->hpa_range.start, cxld->hpa_range.end,
881+
cxld->interleave_ways, cxld->interleave_granularity);
882+
871883
if (!info) {
872884
lo = readl(hdm + CXL_HDM_DECODER0_TL_LOW(which));
873885
hi = readl(hdm + CXL_HDM_DECODER0_TL_HIGH(which));

0 commit comments

Comments
 (0)