Skip to content

Commit c8b16a6

Browse files
chaikenpaulmckrcu
authored andcommitted
rcu: Elevate priority of offloaded callback threads
When CONFIG_PREEMPT_RT=y, the rcutree.kthread_prio command-line parameter signals initialization code to boost the priority of rcuc callbacks to the designated value. With the additional CONFIG_RCU_NOCB_CPU=y configuration and an additional rcu_nocbs command-line parameter, the callbacks on the listed cores are offloaded to new rcuop kthreads that are not pinned to the cores whose post-grace-period work is performed. While the rcuop kthreads perform the same function as the rcuc kthreads they offload, the kthread_prio parameter only boosts the priority of the rcuc kthreads. Fix this inconsistency by elevating rcuop kthreads to the same priority as the rcuc kthreads. Signed-off-by: Alison Chaiken <achaiken@aurora.tech> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
1 parent 54577e2 commit c8b16a6

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

kernel/rcu/tree.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ static void sync_sched_exp_online_cleanup(int cpu);
153153
static void check_cb_ovld_locked(struct rcu_data *rdp, struct rcu_node *rnp);
154154
static bool rcu_rdp_is_offloaded(struct rcu_data *rdp);
155155

156-
/* rcuc/rcub kthread realtime priority */
156+
/* rcuc/rcub/rcuop kthread realtime priority */
157157
static int kthread_prio = IS_ENABLED(CONFIG_RCU_BOOST) ? 1 : 0;
158158
module_param(kthread_prio, int, 0444);
159159

kernel/rcu/tree_nocb.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1270,6 +1270,9 @@ static void rcu_spawn_cpu_nocb_kthread(int cpu)
12701270
"rcuo%c/%d", rcu_state.abbr, cpu);
12711271
if (WARN_ONCE(IS_ERR(t), "%s: Could not start rcuo CB kthread, OOM is now expected behavior\n", __func__))
12721272
return;
1273+
1274+
if (kthread_prio)
1275+
sched_setscheduler_nocheck(t, SCHED_FIFO, &sp);
12731276
WRITE_ONCE(rdp->nocb_cb_kthread, t);
12741277
WRITE_ONCE(rdp->nocb_gp_kthread, rdp_gp->nocb_gp_kthread);
12751278
}

0 commit comments

Comments
 (0)