Skip to content

Commit c8bf0b9

Browse files
Rusydi H. MakarimEric Biggers
authored andcommitted
lib/crypto: md5: Use rol32() instead of open-coding it
For the bitwise left rotation in MD5STEP, use rol32() from <linux/bitops.h> instead of open-coding it. Signed-off-by: Rusydi H. Makarim <rusydi.makarim@kriptograf.id> Link: https://lore.kernel.org/r/20251214-rol32_in_md5-v1-1-20f5f11a92b2@kriptograf.id Signed-off-by: Eric Biggers <ebiggers@kernel.org>
1 parent 0d8e6c0 commit c8bf0b9

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

lib/crypto/md5.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ static const struct md5_block_state md5_iv = {
2929
#define F4(x, y, z) (y ^ (x | ~z))
3030

3131
#define MD5STEP(f, w, x, y, z, in, s) \
32-
(w += f(x, y, z) + in, w = (w << s | w >> (32 - s)) + x)
32+
(w += f(x, y, z) + in, w = rol32(w, s) + x)
3333

3434
static void md5_block_generic(struct md5_block_state *state,
3535
const u8 data[MD5_BLOCK_SIZE])

0 commit comments

Comments
 (0)