Skip to content

Commit c94ea32

Browse files
paliLorenzo Pieralisi
authored andcommitted
PCI: mvebu: Update comment for PCI_EXP_LNKCTL register on emulated bridge
Logic and code for clearing PCI_EXP_LNKCTL_CLKREQ_EN bit is correct, but comment describing it is misleading. PCI_EXP_LNKCTL_CLKREQ_EN bit should be hardwired to zero but mvebu hw allows to change it. Link: https://lore.kernel.org/r/20220104153529.31647-11-pali@kernel.org Signed-off-by: Pali Rohár <pali@kernel.org> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Reviewed-by: Rob Herring <robh@kernel.org>
1 parent d76a6ed commit c94ea32

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

drivers/pci/controller/pci-mvebu.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -663,10 +663,9 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge,
663663

664664
case PCI_EXP_LNKCTL:
665665
/*
666-
* If we don't support CLKREQ, we must ensure that the
667-
* CLKREQ enable bit always reads zero. Since we haven't
668-
* had this capability, and it's dependent on board wiring,
669-
* disable it for the time being.
666+
* PCIe requires that the Enable Clock Power Management bit
667+
* is hard-wired to zero for downstream ports but HW allows
668+
* to change it.
670669
*/
671670
new &= ~PCI_EXP_LNKCTL_CLKREQ_EN;
672671

0 commit comments

Comments
 (0)