Skip to content

Commit c94f732

Browse files
Nirmal PatelLorenzo Pieralisi
authored andcommitted
PCI: vmd: Revert 2565e5b ("PCI: vmd: Do not disable MSI-X remapping if interrupt remapping is enabled by IOMMU.")
Revert 2565e5b ("PCI: vmd: Do not disable MSI-X remapping if interrupt remapping is enabled by IOMMU.") The commit 2565e5b was added as a workaround to keep MSI-X remapping enabled if IOMMU enables interrupt remapping. VMD would keep running in low performance mode. There is no dependency between MSI-X remapping by VMD and interrupt remapping by IOMMU. Link: https://lore.kernel.org/r/20220511095707.25403-3-nirmal.patel@linux.intel.com Signed-off-by: Nirmal Patel <nirmal.patel@linux.intel.com> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
1 parent 886e671 commit c94f732

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

  • drivers/pci/controller

drivers/pci/controller/vmd.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
#include <linux/device.h>
88
#include <linux/interrupt.h>
9-
#include <linux/iommu.h>
109
#include <linux/irq.h>
1110
#include <linux/kernel.h>
1211
#include <linux/module.h>
@@ -813,8 +812,7 @@ static int vmd_enable_domain(struct vmd_dev *vmd, unsigned long features)
813812
* acceptable because the guest is usually CPU-limited and MSI
814813
* remapping doesn't become a performance bottleneck.
815814
*/
816-
if (iommu_capable(vmd->dev->dev.bus, IOMMU_CAP_INTR_REMAP) ||
817-
!(features & VMD_FEAT_CAN_BYPASS_MSI_REMAP) ||
815+
if (!(features & VMD_FEAT_CAN_BYPASS_MSI_REMAP) ||
818816
offset[0] || offset[1]) {
819817
ret = vmd_alloc_irqs(vmd);
820818
if (ret)

0 commit comments

Comments
 (0)