Skip to content

Commit c98cf41

Browse files
committed
hwmon: (jc42) Use common device ID for TSE2004av compliant sensors
TSE2004av standardizes the device ID of compliant temperature sensors to be 0x22xx, where xx is the device revision. Use a single define for all TSE2004av compliant temperature sensors, and relax the device id mask to match the upper 8 bit of the device id register. Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent ef8df81 commit c98cf41

1 file changed

Lines changed: 10 additions & 33 deletions

File tree

drivers/hwmon/jc42.c

Lines changed: 10 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -79,20 +79,9 @@ static const unsigned short normal_i2c[] = {
7979
#define AT30TS00_DEVID 0x8201
8080
#define AT30TS00_DEVID_MASK 0xffff
8181

82-
#define AT30TSE004_DEVID 0x2200
83-
#define AT30TSE004_DEVID_MASK 0xffff
84-
85-
/* Giantec */
86-
#define GT30TS00_DEVID 0x2200
87-
#define GT30TS00_DEVID_MASK 0xff00
88-
8982
#define GT34TS02_DEVID 0x3300
9083
#define GT34TS02_DEVID_MASK 0xff00
9184

92-
/* IDT */
93-
#define TSE2004_DEVID 0x2200
94-
#define TSE2004_DEVID_MASK 0xff00
95-
9685
#define TS3000_DEVID 0x2900 /* Also matches TSE2002 */
9786
#define TS3000_DEVID_MASK 0xff00
9887

@@ -116,9 +105,6 @@ static const unsigned short normal_i2c[] = {
116105
#define MCP98243_DEVID 0x2100
117106
#define MCP98243_DEVID_MASK 0xfffc
118107

119-
#define MCP98244_DEVID 0x2200
120-
#define MCP98244_DEVID_MASK 0xfffc
121-
122108
#define MCP9843_DEVID 0x0000 /* Also matches mcp9805 */
123109
#define MCP9843_DEVID_MASK 0xfffe
124110

@@ -136,12 +122,6 @@ static const unsigned short normal_i2c[] = {
136122
#define CAT34TS02C_DEVID 0x0a00
137123
#define CAT34TS02C_DEVID_MASK 0xfff0
138124

139-
#define CAT34TS04_DEVID 0x2200
140-
#define CAT34TS04_DEVID_MASK 0xfff0
141-
142-
#define N34TS04_DEVID 0x2230
143-
#define N34TS04_DEVID_MASK 0xfff0
144-
145125
/* ST Microelectronics */
146126
#define STTS424_DEVID 0x0101
147127
#define STTS424_DEVID_MASK 0xffff
@@ -152,15 +132,12 @@ static const unsigned short normal_i2c[] = {
152132
#define STTS2002_DEVID 0x0300
153133
#define STTS2002_DEVID_MASK 0xffff
154134

155-
#define STTS2004_DEVID 0x2201
156-
#define STTS2004_DEVID_MASK 0xffff
157-
158135
#define STTS3000_DEVID 0x0200
159136
#define STTS3000_DEVID_MASK 0xffff
160137

161-
/* Seiko Instruments */
162-
#define S34TS04A_DEVID 0x2221
163-
#define S34TS04A_DEVID_MASK 0xffff
138+
/* TSE2004 compliant sensors */
139+
#define TSE2004_DEVID 0x2200
140+
#define TSE2004_DEVID_MASK 0xff00
164141

165142
static u16 jc42_hysteresis[] = { 0, 1500, 3000, 6000 };
166143

@@ -173,8 +150,8 @@ struct jc42_chips {
173150
static struct jc42_chips jc42_chips[] = {
174151
{ ADT_MANID, ADT7408_DEVID, ADT7408_DEVID_MASK },
175152
{ ATMEL_MANID, AT30TS00_DEVID, AT30TS00_DEVID_MASK },
176-
{ ATMEL_MANID2, AT30TSE004_DEVID, AT30TSE004_DEVID_MASK },
177-
{ GT_MANID, GT30TS00_DEVID, GT30TS00_DEVID_MASK },
153+
{ ATMEL_MANID2, TSE2004_DEVID, TSE2004_DEVID_MASK },
154+
{ GT_MANID, TSE2004_DEVID, TSE2004_DEVID_MASK },
178155
{ GT_MANID2, GT34TS02_DEVID, GT34TS02_DEVID_MASK },
179156
{ IDT_MANID, TSE2004_DEVID, TSE2004_DEVID_MASK },
180157
{ IDT_MANID, TS3000_DEVID, TS3000_DEVID_MASK },
@@ -184,19 +161,19 @@ static struct jc42_chips jc42_chips[] = {
184161
{ MCP_MANID, MCP9808_DEVID, MCP9808_DEVID_MASK },
185162
{ MCP_MANID, MCP98242_DEVID, MCP98242_DEVID_MASK },
186163
{ MCP_MANID, MCP98243_DEVID, MCP98243_DEVID_MASK },
187-
{ MCP_MANID, MCP98244_DEVID, MCP98244_DEVID_MASK },
164+
{ MCP_MANID, TSE2004_DEVID, TSE2004_DEVID_MASK },
188165
{ MCP_MANID, MCP9843_DEVID, MCP9843_DEVID_MASK },
189166
{ NXP_MANID, SE97_DEVID, SE97_DEVID_MASK },
190167
{ ONS_MANID, CAT6095_DEVID, CAT6095_DEVID_MASK },
191168
{ ONS_MANID, CAT34TS02C_DEVID, CAT34TS02C_DEVID_MASK },
192-
{ ONS_MANID, CAT34TS04_DEVID, CAT34TS04_DEVID_MASK },
193-
{ ONS_MANID, N34TS04_DEVID, N34TS04_DEVID_MASK },
169+
{ ONS_MANID, TSE2004_DEVID, TSE2004_DEVID_MASK },
170+
{ ONS_MANID, TSE2004_DEVID, TSE2004_DEVID_MASK },
194171
{ NXP_MANID, SE98_DEVID, SE98_DEVID_MASK },
195-
{ SI_MANID, S34TS04A_DEVID, S34TS04A_DEVID_MASK },
172+
{ SI_MANID, TSE2004_DEVID, TSE2004_DEVID_MASK },
196173
{ STM_MANID, STTS424_DEVID, STTS424_DEVID_MASK },
197174
{ STM_MANID, STTS424E_DEVID, STTS424E_DEVID_MASK },
198175
{ STM_MANID, STTS2002_DEVID, STTS2002_DEVID_MASK },
199-
{ STM_MANID, STTS2004_DEVID, STTS2004_DEVID_MASK },
176+
{ STM_MANID, TSE2004_DEVID, TSE2004_DEVID_MASK },
200177
{ STM_MANID, STTS3000_DEVID, STTS3000_DEVID_MASK },
201178
};
202179

0 commit comments

Comments
 (0)