Skip to content

Commit c9f7b0e

Browse files
committed
media: ccs: Discard pm_runtime_put() return value
Passing the pm_runtime_put() return value to callers is not particularly useful. Returning an error code from pm_runtime_put() merely means that it has not queued up a work item to check whether or not the device can be suspended and there are many perfectly valid situations in which that can happen, like after writing "on" to the devices' runtime PM "control" attribute in sysfs for one example. It also happens when the kernel is configured with CONFIG_PM unset. Accordingly, update ccs_post_streamoff() to simply discard the return value of pm_runtime_put() and always return success to the caller. This will facilitate a planned change of the pm_runtime_put() return type to void in the future. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> Link: https://patch.msgid.link/22966634.EfDdHjke4D@rafael.j.wysocki
1 parent 88dcab0 commit c9f7b0e

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/media/i2c/ccs/ccs-core.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1974,7 +1974,9 @@ static int ccs_post_streamoff(struct v4l2_subdev *subdev)
19741974
struct ccs_sensor *sensor = to_ccs_sensor(subdev);
19751975
struct i2c_client *client = v4l2_get_subdevdata(&sensor->src->sd);
19761976

1977-
return pm_runtime_put(&client->dev);
1977+
pm_runtime_put(&client->dev);
1978+
1979+
return 0;
19781980
}
19791981

19801982
static int ccs_enum_mbus_code(struct v4l2_subdev *subdev,

0 commit comments

Comments
 (0)