Skip to content

Commit ca1cedd

Browse files
nathanchanceaalexandrovich
authored andcommitted
ntfs3: Restore NULL folio initialization in ntfs_writepages()
Clang warns (or errors with CONFIG_WERROR=y): fs/ntfs3/inode.c:1021:6: error: variable 'folio' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] 1021 | if (is_resident(ni)) { | ^~~~~~~~~~~~~~~ fs/ntfs3/inode.c:1024:48: note: uninitialized use occurs here 1024 | while ((folio = writeback_iter(mapping, wbc, folio, &err))) | ^~~~~ folio should be initialized to NULL for the first iteration of writeback_iter() to start the loop properly. Restore the NULL initialization of folio that was lost in the recent iomap conversion to clear up the warning. Fixes: 099ef9a ("fs/ntfs3: implement iomap-based file operations") Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/oe-kbuild-all/202601010644.FIhOXy6Y-lkp@intel.com/ Closes: https://lore.kernel.org/r/202601010513.axd56bks-lkp@intel.com/ Signed-off-by: Nathan Chancellor <nathan@kernel.org> [almaz.alexandrovich@paragon-software.com: added a few more tags] Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
1 parent 6b3c83d commit ca1cedd

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/ntfs3/inode.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1019,7 +1019,7 @@ static int ntfs_writepages(struct address_space *mapping,
10191019
return -EIO;
10201020

10211021
if (is_resident(ni)) {
1022-
struct folio *folio;
1022+
struct folio *folio = NULL;
10231023

10241024
while ((folio = writeback_iter(mapping, wbc, folio, &err)))
10251025
err = ntfs_resident_writepage(folio, wbc);

0 commit comments

Comments
 (0)