powerpc/pseries: use kfree_sensitive() in plpks_gen_password()

Minjie Du · mpe · commit ca2b746d5f91 · 2023-10-20T23:22:17.000+11:00
password might contain private information, so better use kfree_sensitive to free it. In plpks_gen_password() use kfree_sensitive(). Signed-off-by: Minjie Du <duminjie@vivo.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://msgid.link/20230717092648.9752-1-duminjie@vivo.com
diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platforms/pseries/plpks.c
@@ -150,7 +150,7 @@ static int plpks_gen_password(void)
 		ospasswordlength = maxpwsize;
 		ospassword = kzalloc(maxpwsize, GFP_KERNEL);
 		if (!ospassword) {
-			kfree(password);
+			kfree_sensitive(password);
 			return -ENOMEM;
 		}
 		memcpy(ospassword, password, ospasswordlength);
@@ -163,7 +163,7 @@ static int plpks_gen_password(void)
 		}
 	}
 out:
-	kfree(password);
+	kfree_sensitive(password);
 
 	return pseries_status_to_err(rc);
 }

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ static int plpks_gen_password(void)`
`150`	`150`	`ospasswordlength = maxpwsize;`
`151`	`151`	`ospassword = kzalloc(maxpwsize, GFP_KERNEL);`
`152`	`152`	`if (!ospassword) {`
`153`		`- kfree(password);`
	`153`	`+ kfree_sensitive(password);`
`154`	`154`	`return -ENOMEM;`
`155`	`155`	`}`
`156`	`156`	`memcpy(ospassword, password, ospasswordlength);`
`@@ -163,7 +163,7 @@ static int plpks_gen_password(void)`
`163`	`163`	`}`
`164`	`164`	`}`
`165`	`165`	`out:`
`166`		`- kfree(password);`
	`166`	`+ kfree_sensitive(password);`
`167`	`167`
`168`	`168`	`return pseries_status_to_err(rc);`
`169`	`169`	`}`