Skip to content

Commit ca637c0

Browse files
dtortsbogend
authored andcommitted
MIPS: DTS: CI20: fix reset line polarity of the ethernet controller
The reset line is called PWRST#, annotated as "active low" in the binding documentation, and is driven low and then high by the driver to reset the chip. However in device tree for CI20 board it was incorrectly marked as "active high". Fix it. Because (as far as I know) the ci20.dts is always built in the kernel I elected not to also add a quirk to gpiolib to force the polarity there. Fixes: db49ca3 ("net: davicom: dm9000: switch to using gpiod API") Reported-by: Paul Cercueil <paul@crapouillou.net> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by: Paul Cercueil <paul@crapouillou.net> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
1 parent 094226a commit ca637c0

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

arch/mips/boot/dts/ingenic/ci20.dts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@
438438
ingenic,nemc-tAW = <50>;
439439
ingenic,nemc-tSTRV = <100>;
440440

441-
reset-gpios = <&gpf 12 GPIO_ACTIVE_HIGH>;
441+
reset-gpios = <&gpf 12 GPIO_ACTIVE_LOW>;
442442
vcc-supply = <&eth0_power>;
443443

444444
interrupt-parent = <&gpe>;

0 commit comments

Comments
 (0)