Skip to content

Commit cab63f6

Browse files
dinghaoliualexandrebelloni
authored andcommitted
i3c: Fix potential refcount leak in i3c_master_register_new_i3c_devs
put_device() needs to be called on failure of device_register() to give up the reference initialized in it to avoid refcount leak. Fixes: 3a379bb ("i3c: Add core I3C infrastructure") Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Link: https://lore.kernel.org/r/20230921082410.25548-1-dinghao.liu@zju.edu.cn Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent fc9176e commit cab63f6

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/i3c/master.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1525,9 +1525,11 @@ i3c_master_register_new_i3c_devs(struct i3c_master_controller *master)
15251525
desc->dev->dev.of_node = desc->boardinfo->of_node;
15261526

15271527
ret = device_register(&desc->dev->dev);
1528-
if (ret)
1528+
if (ret) {
15291529
dev_err(&master->dev,
15301530
"Failed to add I3C device (err = %d)\n", ret);
1531+
put_device(&desc->dev->dev);
1532+
}
15311533
}
15321534
}
15331535

0 commit comments

Comments
 (0)