Skip to content

Commit cb200e4

Browse files
Dan Carpenterandersson
authored andcommitted
remoteproc: qcom: q6v5: Fix NULL vs IS_ERR() bug in q6v5_alloc_memory_region()
The devm_ioremap_resource_wc() function never returns NULL, it returns error pointers. Update the checking to match. Fixes: c70b9d5 ("remoteproc: qcom: Use of_reserved_mem_region_* functions for "memory-region"") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/674b32a78563282adeaf3cdf941314a0b8181026.1764427595.git.dan.carpenter@linaro.org Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent e7839f7 commit cb200e4

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/remoteproc/qcom_q6v5_wcss.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -887,9 +887,9 @@ static int q6v5_alloc_memory_region(struct q6v5_wcss *wcss)
887887
wcss->mem_reloc = res.start;
888888
wcss->mem_size = resource_size(&res);
889889
wcss->mem_region = devm_ioremap_resource_wc(dev, &res);
890-
if (!wcss->mem_region) {
890+
if (IS_ERR(wcss->mem_region)) {
891891
dev_err(dev, "unable to map memory region: %pR\n", &res);
892-
return -EBUSY;
892+
return PTR_ERR(wcss->mem_region);
893893
}
894894

895895
return 0;

0 commit comments

Comments
 (0)