Skip to content

Commit cb58977

Browse files
matrix-wskLucas De Marchi
authored andcommitted
drm/xe: use devm_add_action_or_reset() helper
Use devm_add_action_or_reset() to release resources in case of failure, because the cleanup function will be automatically called. Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Signed-off-by: He Lugang <helugang@uniontech.com> Link: https://patchwork.freedesktop.org/patch/msgid/9631BC17D1E028A2+20240911102215.84865-1-helugang@uniontech.com Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> (cherry picked from commit fdc81c4) Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
1 parent 2d2be27 commit cb58977

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/gpu/drm/xe/xe_gt_freq.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,11 +237,11 @@ int xe_gt_freq_init(struct xe_gt *gt)
237237
if (!gt->freq)
238238
return -ENOMEM;
239239

240-
err = devm_add_action(xe->drm.dev, freq_fini, gt->freq);
240+
err = sysfs_create_files(gt->freq, freq_attrs);
241241
if (err)
242242
return err;
243243

244-
err = sysfs_create_files(gt->freq, freq_attrs);
244+
err = devm_add_action_or_reset(xe->drm.dev, freq_fini, gt->freq);
245245
if (err)
246246
return err;
247247

drivers/gpu/drm/xe/xe_gt_sysfs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,5 @@ int xe_gt_sysfs_init(struct xe_gt *gt)
5151

5252
gt->sysfs = &kg->base;
5353

54-
return devm_add_action(xe->drm.dev, gt_sysfs_fini, gt);
54+
return devm_add_action_or_reset(xe->drm.dev, gt_sysfs_fini, gt);
5555
}

0 commit comments

Comments
 (0)