Skip to content

Commit cb72848

Browse files
Mikulas Patockasnitm
authored andcommitted
dm writecache: fix performance degradation in ssd mode
Fix a thinko in ssd_commit_superblock. region.count is in sectors, not bytes. This bug doesn't corrupt data, but it causes performance degradation. Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> Fixes: dc8a01a ("dm writecache: optimize superblock write") Cc: stable@vger.kernel.org # v5.7+ Reported-by: J. Bruce Fields <bfields@redhat.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
1 parent 09d85f8 commit cb72848

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/md/dm-writecache.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ static void ssd_commit_superblock(struct dm_writecache *wc)
523523

524524
region.bdev = wc->ssd_dev->bdev;
525525
region.sector = 0;
526-
region.count = PAGE_SIZE;
526+
region.count = PAGE_SIZE >> SECTOR_SHIFT;
527527

528528
if (unlikely(region.sector + region.count > wc->metadata_sectors))
529529
region.count = wc->metadata_sectors - region.sector;

0 commit comments

Comments
 (0)