mailbox: Propagate correct error return value

MrVan · Jassi Brar · commit cb7e2ec3706f · 2025-05-26T16:23:39.000-05:00
In case of_property_match_string fails, it makes more sense
to return its error value to caller, not force the value to
ERR_PTR(-EINVAL).

Signed-off-by: Peng Fan &lt;peng.fan@nxp.com&gt;
Signed-off-by: Jassi Brar &lt;jassisinghbrar@gmail.com&gt;
diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c
@@ -458,7 +458,7 @@ struct mbox_chan *mbox_request_channel_byname(struct mbox_client *cl,
 	if (index < 0) {
 		dev_err(cl->dev, "%s() could not locate channel named \"%s\"\n",
 			__func__, name);
-		return ERR_PTR(-EINVAL);
+		return ERR_PTR(index);
 	}
 	return mbox_request_channel(cl, index);
 }

Original file line number	Diff line number	Diff line change
`@@ -458,7 +458,7 @@ struct mbox_chan mbox_request_channel_byname(struct mbox_client cl,`
`458`	`458`	`if (index < 0) {`
`459`	`459`	`dev_err(cl->dev, "%s() could not locate channel named \"%s\"\n",`
`460`	`460`	`__func__, name);`
`461`		`- return ERR_PTR(-EINVAL);`
	`461`	`+ return ERR_PTR(index);`
`462`	`462`	`}`
`463`	`463`	`return mbox_request_channel(cl, index);`
`464`	`464`	`}`