Skip to content

Commit cb80ecf

Browse files
Olga Kornievskaiachucklever
authored andcommitted
NFSD: add cb opcode to WARN_ONCE on failed callback
It helps to know what kind of callback happened that triggered the WARN_ONCE in nfsd4_cb_done() function in diagnosing what can set an uncommon state where both cb_status and tk_status are set at the same time. Signed-off-by: Olga Kornievskaia <okorniev@redhat.com> Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent 1b3e26a commit cb80ecf

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

fs/nfsd/nfs4callback.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1396,8 +1396,9 @@ static void nfsd4_cb_done(struct rpc_task *task, void *calldata)
13961396
return;
13971397

13981398
if (cb->cb_status) {
1399-
WARN_ONCE(task->tk_status, "cb_status=%d tk_status=%d",
1400-
cb->cb_status, task->tk_status);
1399+
WARN_ONCE(task->tk_status,
1400+
"cb_status=%d tk_status=%d cb_opcode=%d",
1401+
cb->cb_status, task->tk_status, cb->cb_ops->opcode);
14011402
task->tk_status = cb->cb_status;
14021403
}
14031404

0 commit comments

Comments
 (0)