Skip to content

Commit cb8435d

Browse files
ebiggerstytso
authored andcommitted
ext4: reject the 'commit' option on ext2 filesystems
The 'commit' option is only applicable for ext3 and ext4 filesystems, and has never been accepted by the ext2 filesystem driver, so the ext4 driver shouldn't allow it on ext2 filesystems. This fixes a failure in xfstest ext4/053. Fixes: 8dc0aa8 ("ext4: check incompatible mount options while mounting ext2/3") Signed-off-by: Eric Biggers <ebiggers@google.com> Reviewed-by: Ritesh Harjani <ritesh.list@gmail.com> Reviewed-by: Lukas Czerner <lczerner@redhat.com> Link: https://lore.kernel.org/r/20220510183232.172615-1-ebiggers@kernel.org
1 parent b10b627 commit cb8435d

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

fs/ext4/super.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1915,6 +1915,7 @@ static const struct mount_opts {
19151915
MOPT_EXT4_ONLY | MOPT_CLEAR},
19161916
{Opt_warn_on_error, EXT4_MOUNT_WARN_ON_ERROR, MOPT_SET},
19171917
{Opt_nowarn_on_error, EXT4_MOUNT_WARN_ON_ERROR, MOPT_CLEAR},
1918+
{Opt_commit, 0, MOPT_NO_EXT2},
19181919
{Opt_nojournal_checksum, EXT4_MOUNT_JOURNAL_CHECKSUM,
19191920
MOPT_EXT4_ONLY | MOPT_CLEAR},
19201921
{Opt_journal_checksum, EXT4_MOUNT_JOURNAL_CHECKSUM,

0 commit comments

Comments
 (0)