Skip to content

Commit cb86a41

Browse files
mrutland-armctmarinas
authored andcommitted
arm64: stacktrace: delete PCS comment
The comment at the top of stacktrace.c isn't all that helpful, as it's not associated with the code which inspects the frame record, and the code example isn't representative of common code generation today. Delete it. There should be no functional change as a result of this patch. Signed-off-by: Mark Rutland <mark.rutland@arm.com> Cc: Madhavan T. Venkataraman <madvenka@linux.microsoft.com> Cc: Mark Brown <broonie@kernel.org> Cc: Will Deacon <will@kernel.org> Reviewed-by: Madhavan T. Venkataraman <madvenka@linux.microsoft.com> Reviewed-by: Mark Brown <broonie@kernel.org> Reviewed-by: Kalesh Singh <kaleshsingh@google.com> for the series. Link: https://lore.kernel.org/r/20220413145910.3060139-3-mark.rutland@arm.com Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
1 parent 4f6277e commit cb86a41

1 file changed

Lines changed: 0 additions & 15 deletions

File tree

arch/arm64/kernel/stacktrace.c

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,6 @@
1818
#include <asm/stack_pointer.h>
1919
#include <asm/stacktrace.h>
2020

21-
/*
22-
* AArch64 PCS assigns the frame pointer to x29.
23-
*
24-
* A simple function prologue looks like this:
25-
* sub sp, sp, #0x10
26-
* stp x29, x30, [sp]
27-
* mov x29, sp
28-
*
29-
* A simple function epilogue looks like this:
30-
* mov sp, x29
31-
* ldp x29, x30, [sp]
32-
* add sp, sp, #0x10
33-
*/
34-
35-
3621
static notrace void start_backtrace(struct stackframe *frame, unsigned long fp,
3722
unsigned long pc)
3823
{

0 commit comments

Comments
 (0)