xfs: reinstate the old i_version counter as STATX_CHANGE_COOKIE

jtlayton · Chandan Babu R · commit cbc06310c36f · 2023-10-12T10:17:03.000+05:30
The handling of STATX_CHANGE_COOKIE was moved into generic_fillattr in commit 0d72b92 (fs: pass the request_mask to generic_fillattr), but we didn't account for the fact that xfs doesn't call generic_fillattr at all. Make XFS report its i_version as the STATX_CHANGE_COOKIE. Fixes: 0d72b92 (fs: pass the request_mask to generic_fillattr) Signed-off-by: Jeff Layton <jlayton@kernel.org> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
@@ -584,6 +584,11 @@ xfs_vn_getattr(
 		}
 	}
 
+	if ((request_mask & STATX_CHANGE_COOKIE) && IS_I_VERSION(inode)) {
+		stat->change_cookie = inode_query_iversion(inode);
+		stat->result_mask |= STATX_CHANGE_COOKIE;
+	}
+
 	/*
 	 * Note: If you add another clause to set an attribute flag, please
 	 * update attributes_mask below.

Original file line number	Diff line number	Diff line change
`@@ -584,6 +584,11 @@ xfs_vn_getattr(`
`584`	`584`	`}`
`585`	`585`	`}`
`586`	`586`
	`587`	`+ if ((request_mask & STATX_CHANGE_COOKIE) && IS_I_VERSION(inode)) {`
	`588`	`+ stat->change_cookie = inode_query_iversion(inode);`
	`589`	`+ stat->result_mask \|= STATX_CHANGE_COOKIE;`
	`590`	`+ }`
	`591`	`+`
`587`	`592`	`/*`
`588`	`593`	`* Note: If you add another clause to set an attribute flag, please`
`589`	`594`	`* update attributes_mask below.`