Skip to content

Commit cbeb989

Browse files
committed
ethtool: don't propagate EOPNOTSUPP from dumps
The default dump handler needs to clear ret before returning. Otherwise if the last interface returns an inconsequential error this error will propagate to user space. This may confuse user space (ethtool CLI seems to ignore it, but YNL doesn't). It will also terminate the dump early for mutli-skb dump, because netlink core treats EOPNOTSUPP as a real error. Fixes: 728480f ("ethtool: default handlers for GET requests") Reviewed-by: Simon Horman <horms@kernel.org> Link: https://lore.kernel.org/r/20231126225806.2143528-1-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 9870257 commit cbeb989

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

net/ethtool/netlink.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -505,6 +505,7 @@ static int ethnl_default_dumpit(struct sk_buff *skb,
505505
ret = skb->len;
506506
break;
507507
}
508+
ret = 0;
508509
}
509510
rtnl_unlock();
510511

0 commit comments

Comments
 (0)