Skip to content

Commit cc5d8ac

Browse files
zhangqilongbroonie
authored andcommitted
ASoC: rockchip: Fix PM usage reference of rockchip_i2s_tdm_resume
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. We fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Fixes:081068fd64140 ("ASoC: rockchip: add support for i2s-tdm controller") Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com> Link: https://lore.kernel.org/r/20220315025415.2593762-1-zhangqilong3@huawei.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent d39664c commit cc5d8ac

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

sound/soc/rockchip/rockchip_i2s_tdm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1738,7 +1738,7 @@ static int __maybe_unused rockchip_i2s_tdm_resume(struct device *dev)
17381738
struct rk_i2s_tdm_dev *i2s_tdm = dev_get_drvdata(dev);
17391739
int ret;
17401740

1741-
ret = pm_runtime_get_sync(dev);
1741+
ret = pm_runtime_resume_and_get(dev);
17421742
if (ret < 0)
17431743
return ret;
17441744
ret = regcache_sync(i2s_tdm->regmap);

0 commit comments

Comments
 (0)