platform/x86/amd: Fix refcount leak in amd_pmc_probe

Yuuoniy · jwrdegoede · commit ccb32e2be142 · 2023-01-12T20:04:38.000+01:00
pci_get_domain_bus_and_slot() takes reference, the caller should release the reference by calling pci_dev_put() after use. Call pci_dev_put() in the error path to fix this. Fixes: 3d7d407 ("platform/x86: amd-pmc: Add support for AMD Spill to DRAM STB feature") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> Link: https://lore.kernel.org/r/20221229072534.1381432-1-linmq006@gmail.com Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c
@@ -932,7 +932,7 @@ static int amd_pmc_probe(struct platform_device *pdev)
 	if (enable_stb && (dev->cpu_id == AMD_CPU_ID_YC || dev->cpu_id == AMD_CPU_ID_CB)) {
 		err = amd_pmc_s2d_init(dev);
 		if (err)
-			return err;
+			goto err_pci_dev_put;
 	}
 
 	platform_set_drvdata(pdev, dev);

Original file line number	Diff line number	Diff line change
`@@ -932,7 +932,7 @@ static int amd_pmc_probe(struct platform_device *pdev)`
`932`	`932`	`if (enable_stb && (dev->cpu_id == AMD_CPU_ID_YC \|\| dev->cpu_id == AMD_CPU_ID_CB)) {`
`933`	`933`	`err = amd_pmc_s2d_init(dev);`
`934`	`934`	`if (err)`
`935`		`- return err;`
	`935`	`+ goto err_pci_dev_put;`
`936`	`936`	`}`
`937`	`937`
`938`	`938`	`platform_set_drvdata(pdev, dev);`