Skip to content

Commit ccb541a

Browse files
cujomalaineybroonie
authored andcommitted
ASoC: SOF: ipc: Add no reply inline calls
95% of the calls inside SOF to TX an IPC don't care about a reply. Yet the previous commit cleaned up a bunch of replies that were being populated and then thrown away. This adds some functions so users who do not need replies don't feel obligated to provide the space to the API. Signed-off-by: Curtis Malainey <cujomalainey@chromium.org> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Link: https://lore.kernel.org/r/20230419194057.42205-2-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 09cda70 commit ccb541a

2 files changed

Lines changed: 14 additions & 0 deletions

File tree

sound/soc/sof/sof-client.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,10 @@ struct sof_client_dev {
3939

4040
int sof_client_ipc_tx_message(struct sof_client_dev *cdev, void *ipc_msg,
4141
void *reply_data, size_t reply_bytes);
42+
static inline int sof_client_ipc_tx_message_no_reply(struct sof_client_dev *cdev, void *ipc_msg)
43+
{
44+
return sof_client_ipc_tx_message(cdev, ipc_msg, NULL, 0);
45+
}
4246
int sof_client_ipc_set_get_data(struct sof_client_dev *cdev, void *ipc_msg,
4347
bool set);
4448

sound/soc/sof/sof-priv.h

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -711,10 +711,20 @@ static inline void snd_sof_ipc_msgs_rx(struct snd_sof_dev *sdev)
711711
}
712712
int sof_ipc_tx_message(struct snd_sof_ipc *ipc, void *msg_data, size_t msg_bytes,
713713
void *reply_data, size_t reply_bytes);
714+
static inline int sof_ipc_tx_message_no_reply(struct snd_sof_ipc *ipc, void *msg_data,
715+
size_t msg_bytes)
716+
{
717+
return sof_ipc_tx_message(ipc, msg_data, msg_bytes, NULL, 0);
718+
}
714719
int sof_ipc_set_get_data(struct snd_sof_ipc *ipc, void *msg_data,
715720
size_t msg_bytes, bool set);
716721
int sof_ipc_tx_message_no_pm(struct snd_sof_ipc *ipc, void *msg_data, size_t msg_bytes,
717722
void *reply_data, size_t reply_bytes);
723+
static inline int sof_ipc_tx_message_no_pm_no_reply(struct snd_sof_ipc *ipc, void *msg_data,
724+
size_t msg_bytes)
725+
{
726+
return sof_ipc_tx_message_no_pm(ipc, msg_data, msg_bytes, NULL, 0);
727+
}
718728
int sof_ipc_send_msg(struct snd_sof_dev *sdev, void *msg_data, size_t msg_bytes,
719729
size_t reply_bytes);
720730

0 commit comments

Comments
 (0)