hwrng: bcm2835 - Move MODULE_DEVICE_TABLE() to table definition

krzk · herbertx · commit cdd7bbce7b50 · 2025-11-14T18:15:48.000+08:00
Convention is to place MODULE_DEVICE_TABLE() immediately after
definition of the affected table, so one can easily spot missing such.
There is on the other hand no benefits of putting MODULE_DEVICE_TABLE()
far away.

Reviewed-by: Florian Fainelli &lt;florian.fainelli@broadcom.com&gt;
Signed-off-by: Krzysztof Kozlowski &lt;krzysztof.kozlowski@linaro.org&gt;
Signed-off-by: Herbert Xu &lt;herbert@gondor.apana.org.au&gt;
diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835-rng.c
@@ -138,6 +138,7 @@ static const struct of_device_id bcm2835_rng_of_match[] = {
 	{ .compatible = "brcm,bcm6368-rng"},
 	{},
 };
+MODULE_DEVICE_TABLE(of, bcm2835_rng_of_match);
 
 static int bcm2835_rng_probe(struct platform_device *pdev)
 {
@@ -191,8 +192,6 @@ static int bcm2835_rng_probe(struct platform_device *pdev)
 	return err;
 }
 
-MODULE_DEVICE_TABLE(of, bcm2835_rng_of_match);
-
 static const struct platform_device_id bcm2835_rng_devtype[] = {
 	{ .name = "bcm2835-rng" },
 	{ .name = "bcm63xx-rng" },

Original file line number	Diff line number	Diff line change
`@@ -138,6 +138,7 @@ static const struct of_device_id bcm2835_rng_of_match[] = {`
`138`	`138`	`{ .compatible = "brcm,bcm6368-rng"},`
`139`	`139`	`{},`
`140`	`140`	`};`
	`141`	`+MODULE_DEVICE_TABLE(of, bcm2835_rng_of_match);`
`141`	`142`
`142`	`143`	`static int bcm2835_rng_probe(struct platform_device *pdev)`
`143`	`144`	`{`
`@@ -191,8 +192,6 @@ static int bcm2835_rng_probe(struct platform_device *pdev)`
`191`	`192`	`return err;`
`192`	`193`	`}`
`193`	`194`
`194`		`-MODULE_DEVICE_TABLE(of, bcm2835_rng_of_match);`
`195`		`-`
`196`	`195`	`static const struct platform_device_id bcm2835_rng_devtype[] = {`
`197`	`196`	`{ .name = "bcm2835-rng" },`
`198`	`197`	`{ .name = "bcm63xx-rng" },`