irqchip/armada-370-xp: Fix return value of armada_370_xp_msi_alloc()

pali · Marc Zyngier · commit ce20eff57361 · 2021-11-25T16:49:38.000Z
IRQ domain alloc function should return zero on success. Non-zero value indicates failure. Signed-off-by: Pali Rohár <pali@kernel.org> Fixes: fcc392d ("irqchip/armada-370-xp: Use the generic MSI infrastructure") Cc: stable@vger.kernel.org Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20211125130057.26705-1-pali@kernel.org
diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c
@@ -250,7 +250,7 @@ static int armada_370_xp_msi_alloc(struct irq_domain *domain, unsigned int virq,
 				    NULL, NULL);
 	}
 
-	return hwirq;
+	return 0;
 }
 
 static void armada_370_xp_msi_free(struct irq_domain *domain,

Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,7 @@ static int armada_370_xp_msi_alloc(struct irq_domain *domain, unsigned int virq,`
`250`	`250`	`NULL, NULL);`
`251`	`251`	`}`
`252`	`252`
`253`		`- return hwirq;`
	`253`	`+ return 0;`
`254`	`254`	`}`
`255`	`255`
`256`	`256`	`static void armada_370_xp_msi_free(struct irq_domain *domain,`