Skip to content

Commit ce3b32e

Browse files
ChunTao Tsoalexdeucher
authored andcommitted
drm/amd/display: amend HPD handler for Replay
[Why] For Replay, if we receive HPD, it doesn’t need to reboot the display. We don’t need to return anything exactly. [How] Return nothing just because we don’t need to reboot the display. Signed-off-by: ChunTao Tso <chuntao.tso@amd.com> Acked-by: Hersen Wu <hersenxs.wu@amd.com> Reviewed-by: Jerry Zuo <jerry.zuo@amd.com> Tested-by: Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 39ad51c commit ce3b32e

1 file changed

Lines changed: 4 additions & 7 deletions

File tree

drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_irq_handler.c

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -184,17 +184,17 @@ static bool handle_hpd_irq_psr_sink(struct dc_link *link)
184184
return false;
185185
}
186186

187-
static bool handle_hpd_irq_replay_sink(struct dc_link *link)
187+
static void handle_hpd_irq_replay_sink(struct dc_link *link)
188188
{
189189
union dpcd_replay_configuration replay_configuration;
190190
/*AMD Replay version reuse DP_PSR_ERROR_STATUS for REPLAY_ERROR status.*/
191191
union psr_error_status replay_error_status;
192192

193193
if (link->replay_settings.config.force_disable_desync_error_check)
194-
return true;
194+
return;
195195

196196
if (!link->replay_settings.replay_feature_enabled)
197-
return false;
197+
return;
198198

199199
dm_helpers_dp_read_dpcd(
200200
link->ctx,
@@ -246,7 +246,6 @@ static bool handle_hpd_irq_replay_sink(struct dc_link *link)
246246
edp_set_replay_allow_active(link, &allow_active, true, false, NULL);
247247
}
248248
}
249-
return true;
250249
}
251250

252251
void dp_handle_link_loss(struct dc_link *link)
@@ -427,9 +426,7 @@ bool dp_handle_hpd_rx_irq(struct dc_link *link,
427426
/* PSR-related error was detected and handled */
428427
return true;
429428

430-
if (handle_hpd_irq_replay_sink(link))
431-
/* Replay-related error was detected and handled */
432-
return true;
429+
handle_hpd_irq_replay_sink(link);
433430

434431
/* If PSR-related error handled, Main link may be off,
435432
* so do not handle as a normal sink status change interrupt.

0 commit comments

Comments
 (0)