Skip to content

Commit cea5d43

Browse files
Dan CarpenterpH5
authored andcommitted
reset: rzg2l-usbphy-ctrl: Fix a NULL vs IS_ERR() bug in probe
The devm_regmap_field_alloc() function never returns NULL, it returns error pointers. Update the error checking to match. Fixes: 58128aa ("reset: rzg2l-usbphy-ctrl: Add support for USB PWRRDY") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
1 parent da91533 commit cea5d43

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/reset/reset-rzg2l-usbphy-ctrl.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,8 @@ static int rzg2l_usbphy_ctrl_pwrrdy_init(struct device *dev)
158158
field.msb = __fls(args[1]);
159159

160160
pwrrdy = devm_regmap_field_alloc(dev, regmap, field);
161-
if (!pwrrdy)
162-
return -ENOMEM;
161+
if (IS_ERR(pwrrdy))
162+
return PTR_ERR(pwrrdy);
163163

164164
rzg2l_usbphy_ctrl_set_pwrrdy(pwrrdy, true);
165165

0 commit comments

Comments
 (0)