Skip to content

Commit ceb3bfa

Browse files
Phil Edworthygeertu
authored andcommitted
clk: renesas: rzg2l: Move the DEF_MUX array size calc into the macro
We only ever use ARRAY_SIZE() to populate the number of parents, so move this into the macro to always detect it automatically. This also makes the tables of clocks a little simpler. Similarly for the DEF_SD_MUX macro. Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> Link: https://lore.kernel.org/r/20220503115557.53370-6-phil.edworthy@renesas.com Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
1 parent 4a52695 commit ceb3bfa

3 files changed

Lines changed: 19 additions & 22 deletions

File tree

drivers/clk/renesas/r9a07g043-cpg.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ static const struct cpg_core_clk r9a07g043_core_clks[] __initconst = {
9999
DEF_FIXED(".pll3_400", CLK_PLL3_400, CLK_PLL3, 1, 4),
100100
DEF_FIXED(".pll3_533", CLK_PLL3_533, CLK_PLL3, 1, 3),
101101
DEF_MUX(".sel_pll3_3", CLK_SEL_PLL3_3, SEL_PLL3_3,
102-
sel_pll3_3, ARRAY_SIZE(sel_pll3_3), 0, CLK_MUX_READ_ONLY),
102+
sel_pll3_3, 0, CLK_MUX_READ_ONLY),
103103
DEF_DIV("divpl3c", CLK_DIV_PLL3_C, CLK_SEL_PLL3_3,
104104
DIVPL3C, dtable_1_32, CLK_DIVIDER_HIWORD_MASK),
105105
DEF_FIXED(".pll5", CLK_PLL5, CLK_EXTAL, 125, 1),
@@ -123,13 +123,11 @@ static const struct cpg_core_clk r9a07g043_core_clks[] __initconst = {
123123
DEF_FIXED("M0", R9A07G043_CLK_M0, CLK_PLL3_DIV2_4, 1, 1),
124124
DEF_FIXED("ZT", R9A07G043_CLK_ZT, CLK_PLL3_DIV2_4_2, 1, 1),
125125
DEF_MUX("HP", R9A07G043_CLK_HP, SEL_PLL6_2,
126-
sel_pll6_2, ARRAY_SIZE(sel_pll6_2), 0, CLK_MUX_HIWORD_MASK),
126+
sel_pll6_2, 0, CLK_MUX_HIWORD_MASK),
127127
DEF_FIXED("SPI0", R9A07G043_CLK_SPI0, CLK_DIV_PLL3_C, 1, 2),
128128
DEF_FIXED("SPI1", R9A07G043_CLK_SPI1, CLK_DIV_PLL3_C, 1, 4),
129-
DEF_SD_MUX("SD0", R9A07G043_CLK_SD0, SEL_SDHI0,
130-
sel_shdi, ARRAY_SIZE(sel_shdi)),
131-
DEF_SD_MUX("SD1", R9A07G043_CLK_SD1, SEL_SDHI1,
132-
sel_shdi, ARRAY_SIZE(sel_shdi)),
129+
DEF_SD_MUX("SD0", R9A07G043_CLK_SD0, SEL_SDHI0, sel_shdi),
130+
DEF_SD_MUX("SD1", R9A07G043_CLK_SD1, SEL_SDHI1, sel_shdi),
133131
DEF_FIXED("SD0_DIV4", CLK_SD0_DIV4, R9A07G043_CLK_SD0, 1, 4),
134132
DEF_FIXED("SD1_DIV4", CLK_SD1_DIV4, R9A07G043_CLK_SD1, 1, 4),
135133
};

drivers/clk/renesas/r9a07g044-cpg.c

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -139,18 +139,17 @@ static const struct {
139139
DEF_FIXED(".pll3_div2_4", CLK_PLL3_DIV2_4, CLK_PLL3_DIV2, 1, 4),
140140
DEF_FIXED(".pll3_div2_4_2", CLK_PLL3_DIV2_4_2, CLK_PLL3_DIV2_4, 1, 2),
141141
DEF_MUX(".sel_pll3_3", CLK_SEL_PLL3_3, SEL_PLL3_3,
142-
sel_pll3_3, ARRAY_SIZE(sel_pll3_3), 0, CLK_MUX_READ_ONLY),
142+
sel_pll3_3, 0, CLK_MUX_READ_ONLY),
143143
DEF_DIV("divpl3c", CLK_DIV_PLL3_C, CLK_SEL_PLL3_3,
144144
DIVPL3C, dtable_1_32, CLK_DIVIDER_HIWORD_MASK),
145145

146146
DEF_FIXED(".pll5_250", CLK_PLL5_250, CLK_PLL5_FOUT3, 1, 2),
147147
DEF_FIXED(".pll6_250", CLK_PLL6_250, CLK_PLL6, 1, 2),
148148
DEF_MUX(".sel_gpu2", CLK_SEL_GPU2, SEL_GPU2,
149-
sel_gpu2, ARRAY_SIZE(sel_gpu2), 0, CLK_MUX_READ_ONLY),
149+
sel_gpu2, 0, CLK_MUX_READ_ONLY),
150150
DEF_PLL5_FOUTPOSTDIV(".pll5_foutpostdiv", CLK_PLL5_FOUTPOSTDIV, CLK_EXTAL),
151151
DEF_FIXED(".pll5_fout1ph0", CLK_PLL5_FOUT1PH0, CLK_PLL5_FOUTPOSTDIV, 1, 2),
152-
DEF_PLL5_4_MUX(".sel_pll5_4", CLK_SEL_PLL5_4, SEL_PLL5_4,
153-
sel_pll5_4, ARRAY_SIZE(sel_pll5_4)),
152+
DEF_PLL5_4_MUX(".sel_pll5_4", CLK_SEL_PLL5_4, SEL_PLL5_4, sel_pll5_4),
154153
DEF_DIV(".div_dsi_lpclk", CLK_DIV_DSI_LPCLK, CLK_PLL2_533_DIV2,
155154
DIVDSILPCLK, dtable_16_128, CLK_DIVIDER_HIWORD_MASK),
156155

@@ -169,13 +168,11 @@ static const struct {
169168
DEF_FIXED("M0", R9A07G044_CLK_M0, CLK_PLL3_DIV2_4, 1, 1),
170169
DEF_FIXED("ZT", R9A07G044_CLK_ZT, CLK_PLL3_DIV2_4_2, 1, 1),
171170
DEF_MUX("HP", R9A07G044_CLK_HP, SEL_PLL6_2,
172-
sel_pll6_2, ARRAY_SIZE(sel_pll6_2), 0, CLK_MUX_HIWORD_MASK),
171+
sel_pll6_2, 0, CLK_MUX_HIWORD_MASK),
173172
DEF_FIXED("SPI0", R9A07G044_CLK_SPI0, CLK_DIV_PLL3_C, 1, 2),
174173
DEF_FIXED("SPI1", R9A07G044_CLK_SPI1, CLK_DIV_PLL3_C, 1, 4),
175-
DEF_SD_MUX("SD0", R9A07G044_CLK_SD0, SEL_SDHI0,
176-
sel_shdi, ARRAY_SIZE(sel_shdi)),
177-
DEF_SD_MUX("SD1", R9A07G044_CLK_SD1, SEL_SDHI1,
178-
sel_shdi, ARRAY_SIZE(sel_shdi)),
174+
DEF_SD_MUX("SD0", R9A07G044_CLK_SD0, SEL_SDHI0, sel_shdi),
175+
DEF_SD_MUX("SD1", R9A07G044_CLK_SD1, SEL_SDHI1, sel_shdi),
179176
DEF_FIXED("SD0_DIV4", CLK_SD0_DIV4, R9A07G044_CLK_SD0, 1, 4),
180177
DEF_FIXED("SD1_DIV4", CLK_SD1_DIV4, R9A07G044_CLK_SD1, 1, 4),
181178
DEF_DIV("G", R9A07G044_CLK_G, CLK_SEL_GPU2, DIVGPU, dtable_1_8,

drivers/clk/renesas/rzg2l-cpg.h

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -138,19 +138,21 @@ enum clk_types {
138138
#define DEF_DIV(_name, _id, _parent, _conf, _dtable, _flag) \
139139
DEF_TYPE(_name, _id, CLK_TYPE_DIV, .conf = _conf, \
140140
.parent = _parent, .dtable = _dtable, .flag = _flag)
141-
#define DEF_MUX(_name, _id, _conf, _parent_names, _num_parents, _flag, \
142-
_mux_flags) \
141+
#define DEF_MUX(_name, _id, _conf, _parent_names, _flag, _mux_flags) \
143142
DEF_TYPE(_name, _id, CLK_TYPE_MUX, .conf = _conf, \
144-
.parent_names = _parent_names, .num_parents = _num_parents, \
143+
.parent_names = _parent_names, \
144+
.num_parents = ARRAY_SIZE(_parent_names), \
145145
.flag = _flag, .mux_flags = _mux_flags)
146-
#define DEF_SD_MUX(_name, _id, _conf, _parent_names, _num_parents) \
146+
#define DEF_SD_MUX(_name, _id, _conf, _parent_names) \
147147
DEF_TYPE(_name, _id, CLK_TYPE_SD_MUX, .conf = _conf, \
148-
.parent_names = _parent_names, .num_parents = _num_parents)
148+
.parent_names = _parent_names, \
149+
.num_parents = ARRAY_SIZE(_parent_names))
149150
#define DEF_PLL5_FOUTPOSTDIV(_name, _id, _parent) \
150151
DEF_TYPE(_name, _id, CLK_TYPE_SIPLL5, .parent = _parent)
151-
#define DEF_PLL5_4_MUX(_name, _id, _conf, _parent_names, _num_parents) \
152+
#define DEF_PLL5_4_MUX(_name, _id, _conf, _parent_names) \
152153
DEF_TYPE(_name, _id, CLK_TYPE_PLL5_4_MUX, .conf = _conf, \
153-
.parent_names = _parent_names, .num_parents = _num_parents)
154+
.parent_names = _parent_names, \
155+
.num_parents = ARRAY_SIZE(_parent_names))
154156
#define DEF_DSI_DIV(_name, _id, _parent, _flag) \
155157
DEF_TYPE(_name, _id, CLK_TYPE_DSI_DIV, .parent = _parent, .flag = _flag)
156158

0 commit comments

Comments
 (0)