fs: fix incorrect fmode_t casts

Min-Hua · brauner · commit cedd0bdc1660 · 2023-05-15T13:14:01.000+02:00
Use __FMODE_NONOTIFY instead of FMODE_NONOTIFY to fixes
the following sparce warnings:
fs/overlayfs/file.c:48:37: sparse: warning: restricted fmode_t degrades to integer
fs/overlayfs/file.c:128:13: sparse: warning: restricted fmode_t degrades to integer
fs/open.c:1159:21: sparse: warning: restricted fmode_t degrades to integer

Signed-off-by: Min-Hua Chen &lt;minhuadotchen@gmail.com&gt;
Message-Id: &lt;20230502232210.119063-1-minhuadotchen@gmail.com&gt;
Signed-off-by: Christian Brauner &lt;brauner@kernel.org&gt;
diff --git a/fs/open.c b/fs/open.c
@@ -1148,7 +1148,7 @@ inline struct open_how build_open_how(int flags, umode_t mode)
 inline int build_open_flags(const struct open_how *how, struct open_flags *op)
 {
 	u64 flags = how->flags;
-	u64 strip = FMODE_NONOTIFY | O_CLOEXEC;
+	u64 strip = __FMODE_NONOTIFY | O_CLOEXEC;
 	int lookup_flags = 0;
 	int acc_mode = ACC_MODE(flags);
 
diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
@@ -35,7 +35,7 @@ static char ovl_whatisit(struct inode *inode, struct inode *realinode)
 }
 
 /* No atime modification nor notify on underlying */
-#define OVL_OPEN_FLAGS (O_NOATIME | FMODE_NONOTIFY)
+#define OVL_OPEN_FLAGS (O_NOATIME | __FMODE_NONOTIFY)
 
 static struct file *ovl_open_realfile(const struct file *file,
 				      const struct path *realpath)

Original file line number	Diff line number	Diff line change
`@@ -1148,7 +1148,7 @@ inline struct open_how build_open_how(int flags, umode_t mode)`
`1148`	`1148`	`inline int build_open_flags(const struct open_how how, struct open_flags op)`
`1149`	`1149`	`{`
`1150`	`1150`	`u64 flags = how->flags;`
`1151`		`- u64 strip = FMODE_NONOTIFY \| O_CLOEXEC;`
	`1151`	`+ u64 strip = __FMODE_NONOTIFY \| O_CLOEXEC;`
`1152`	`1152`	`int lookup_flags = 0;`
`1153`	`1153`	`int acc_mode = ACC_MODE(flags);`
`1154`	`1154`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ static char ovl_whatisit(struct inode inode, struct inode realinode)`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`/* No atime modification nor notify on underlying */`
`38`		`-#define OVL_OPEN_FLAGS (O_NOATIME \| FMODE_NONOTIFY)`
	`38`	`+#define OVL_OPEN_FLAGS (O_NOATIME \| __FMODE_NONOTIFY)`
`39`	`39`
`40`	`40`	`static struct file ovl_open_realfile(const struct file file,`
`41`	`41`	`const struct path *realpath)`