pds_vdpa: set features order

emusln · mstsirkin · commit cefc9ba6aed4 · 2023-12-01T09:55:01.000-05:00
Fix up the order that the device and negotiated features
are checked to get a more reliable difference when things
get changed.

Signed-off-by: Shannon Nelson &lt;shannon.nelson@amd.com&gt;
Message-Id: &lt;20231110221802.46841-4-shannon.nelson@amd.com&gt;
Signed-off-by: Michael S. Tsirkin &lt;mst@redhat.com&gt;
Acked-by: Jason Wang &lt;jasowang@redhat.com&gt;
diff --git a/drivers/vdpa/pds/vdpa_dev.c b/drivers/vdpa/pds/vdpa_dev.c
@@ -318,9 +318,8 @@ static int pds_vdpa_set_driver_features(struct vdpa_device *vdpa_dev, u64 featur
 		return -EOPNOTSUPP;
 	}
 
-	pdsv->negotiated_features = nego_features;
-
 	driver_features = pds_vdpa_get_driver_features(vdpa_dev);
+	pdsv->negotiated_features = nego_features;
 	dev_dbg(dev, "%s: %#llx => %#llx\n",
 		__func__, driver_features, nego_features);
 

Original file line number	Diff line number	Diff line change
`@@ -318,9 +318,8 @@ static int pds_vdpa_set_driver_features(struct vdpa_device *vdpa_dev, u64 featur`
`318`	`318`	`return -EOPNOTSUPP;`
`319`	`319`	`}`
`320`	`320`
`321`		`- pdsv->negotiated_features = nego_features;`
`322`		`-`
`323`	`321`	`driver_features = pds_vdpa_get_driver_features(vdpa_dev);`
	`322`	`+ pdsv->negotiated_features = nego_features;`
`324`	`323`	`dev_dbg(dev, "%s: %#llx => %#llx\n",`
`325`	`324`	`__func__, driver_features, nego_features);`
`326`	`325`