ASoC: codecs: aw88395: Fix some error codes

Dan Carpenter · broonie · commit cf0ba445f5e4 · 2023-09-13T13:58:24.000+01:00
These error paths should return -EINVAL instead of success. Fixes: 7f4ec77 ("ASoC: codecs: Add code for bin parsing compatible with aw88261") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/81476e78-05c2-4656-b754-f314c7ccdb81@moroto.mountain Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/codecs/aw88395/aw88395_lib.c b/sound/soc/codecs/aw88395/aw88395_lib.c
@@ -452,11 +452,13 @@ static int aw_dev_parse_reg_bin_with_hdr(struct aw_device *aw_dev,
 	if ((aw_bin->all_bin_parse_num != 1) ||
 		(aw_bin->header_info[0].bin_data_type != DATA_TYPE_REGISTER)) {
 		dev_err(aw_dev->dev, "bin num or type error");
+		ret = -EINVAL;
 		goto parse_bin_failed;
 	}
 
 	if (aw_bin->header_info[0].valid_data_len % 4) {
 		dev_err(aw_dev->dev, "bin data len get error!");
+		ret = -EINVAL;
 		goto parse_bin_failed;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -452,11 +452,13 @@ static int aw_dev_parse_reg_bin_with_hdr(struct aw_device *aw_dev,`
`452`	`452`	`if ((aw_bin->all_bin_parse_num != 1) \|\|`
`453`	`453`	`(aw_bin->header_info[0].bin_data_type != DATA_TYPE_REGISTER)) {`
`454`	`454`	`dev_err(aw_dev->dev, "bin num or type error");`
	`455`	`+ ret = -EINVAL;`
`455`	`456`	`goto parse_bin_failed;`
`456`	`457`	`}`
`457`	`458`
`458`	`459`	`if (aw_bin->header_info[0].valid_data_len % 4) {`
`459`	`460`	`dev_err(aw_dev->dev, "bin data len get error!");`
	`461`	`+ ret = -EINVAL;`
`460`	`462`	`goto parse_bin_failed;`
`461`	`463`	`}`
`462`	`464`