drm/nouveau/acr/ga102: set variable ga102_gsps storage-class-specifier to static

Tom Rix · karolherbst · commit cf0c4bc9e4e1 · 2023-05-22T16:39:04.000+02:00
smatch reports drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c:49:1: warning: symbol 'ga102_gsps' was not declared. Should it be static? This variable is only used in its defining file, so it should be static Signed-off-by: Tom Rix <trix@redhat.com> Reviewed-by: Karol Herbst <kherbst@redhat.com> Signed-off-by: Karol Herbst <kherbst@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230517133112.873856-1-trix@redhat.com
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c
@@ -45,7 +45,7 @@ ga102_gsp_nofw(struct nvkm_gsp *gsp, int ver, const struct nvkm_gsp_fwif *fwif)
 	return 0;
 }
 
-struct nvkm_gsp_fwif
+static struct nvkm_gsp_fwif
 ga102_gsps[] = {
 	{ -1, ga102_gsp_nofw, &ga102_gsp },
 	{}

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ ga102_gsp_nofw(struct nvkm_gsp gsp, int ver, const struct nvkm_gsp_fwif fwif)`
`45`	`45`	`return 0;`
`46`	`46`	`}`
`47`	`47`
`48`		`-struct nvkm_gsp_fwif`
	`48`	`+static struct nvkm_gsp_fwif`
`49`	`49`	`ga102_gsps[] = {`
`50`	`50`	`{ -1, ga102_gsp_nofw, &ga102_gsp },`
`51`	`51`	`{}`