Skip to content

Commit cf3be7e

Browse files
Uwe Kleine-KönigWim Van Sebroeck
authored andcommitted
watchdog: at91rm9200: Only warn once about problems in .remove()
The single difference between returning 0 and returning an error code in a platform remove callback is that in the latter case the platform core emits a warning about the error being ignored. at91wdt_remove() already emits a warning in the error case, so suppress the more generic (and less helpful) one by returning 0. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Link: https://lore.kernel.org/r/20230217095317.1213387-1-u.kleine-koenig@pengutronix.de Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
1 parent ff8ec4a commit cf3be7e

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/watchdog/at91rm9200_wdt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ static int at91wdt_remove(struct platform_device *pdev)
270270
misc_deregister(&at91wdt_miscdev);
271271
at91wdt_miscdev.parent = NULL;
272272

273-
return res;
273+
return 0;
274274
}
275275

276276
static void at91wdt_shutdown(struct platform_device *pdev)

0 commit comments

Comments
 (0)