Skip to content

Commit cf4a869

Browse files
huangshaoqinbonzini
authored andcommitted
KVM: x86/mmu: Check every prev_roots in __kvm_mmu_free_obsolete_roots()
When freeing obsolete previous roots, check prev_roots as intended, not the current root. Signed-off-by: Shaoqin Huang <shaoqin.huang@intel.com> Fixes: 527d5cd ("KVM: x86/mmu: Zap only obsolete roots if a root shadow page is zapped") Message-Id: <20220607005905.2933378-1-shaoqin.huang@intel.com> Cc: stable@vger.kernel.org Reviewed-by: Sean Christopherson <seanjc@google.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
1 parent 3e68490 commit cf4a869

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

arch/x86/kvm/mmu/mmu.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5179,7 +5179,7 @@ static void __kvm_mmu_free_obsolete_roots(struct kvm *kvm, struct kvm_mmu *mmu)
51795179
roots_to_free |= KVM_MMU_ROOT_CURRENT;
51805180

51815181
for (i = 0; i < KVM_MMU_NUM_PREV_ROOTS; i++) {
5182-
if (is_obsolete_root(kvm, mmu->root.hpa))
5182+
if (is_obsolete_root(kvm, mmu->prev_roots[i].hpa))
51835183
roots_to_free |= KVM_MMU_ROOT_PREVIOUS(i);
51845184
}
51855185

0 commit comments

Comments
 (0)