Skip to content

Commit cf7f273

Browse files
committed
erofs: use HIPRI by default if per-cpu kthreads are enabled
As Sandeep shown [1], high priority RT per-cpu kthreads are typically helpful for Android scenarios to minimize the scheduling latencies. Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if EROFS_FS_PCPU_KTHREAD is on since it's the typical use cases for EROFS_FS_PCPU_KTHREAD. Also clean up unneeded sched_set_normal(). [1] https://lore.kernel.org/r/CAB=BE-SBtO6vcoyLNA9F-9VaN5R0t3o_Zn+FW8GbO6wyUqFneQ@mail.gmail.com Reviewed-by: Yue Hu <huyue2@coolpad.com> Reviewed-by: Sandeep Dhavale <dhavale@google.com> Reviewed-by: Chao Yu <chao@kernel.org> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com> Link: https://lore.kernel.org/r/20230522092141.124290-1-hsiangkao@linux.alibaba.com
1 parent 285d0f8 commit cf7f273

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

fs/erofs/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ config EROFS_FS_PCPU_KTHREAD
121121
config EROFS_FS_PCPU_KTHREAD_HIPRI
122122
bool "EROFS high priority per-CPU kthread workers"
123123
depends on EROFS_FS_ZIP && EROFS_FS_PCPU_KTHREAD
124+
default y
124125
help
125126
This permits EROFS to configure per-CPU kthread workers to run
126127
at higher priority.

fs/erofs/zdata.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -369,8 +369,6 @@ static struct kthread_worker *erofs_init_percpu_worker(int cpu)
369369
return worker;
370370
if (IS_ENABLED(CONFIG_EROFS_FS_PCPU_KTHREAD_HIPRI))
371371
sched_set_fifo_low(worker->task);
372-
else
373-
sched_set_normal(worker->task, 0);
374372
return worker;
375373
}
376374

0 commit comments

Comments
 (0)