binfmt_elf: fix documented return value for load_elf_phdrs()

DerDakon · kees · commit cfc46ca4fdca · 2022-10-25T15:19:52.000-07:00
This function has never returned anything but a plain NULL. Fixes: 6a8d389 ("binfmt_elf: Hoist ELF program header loading to a function") Signed-off-by: Rolf Eike Beer <eb@emlix.com> Signed-off-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/2359389.EDbqzprbEW@mobilepool36.emlix.com
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
@@ -456,7 +456,7 @@ static unsigned long maximum_alignment(struct elf_phdr *cmds, int nr)
  *
  * Loads ELF program headers from the binary file elf_file, which has the ELF
  * header pointed to by elf_ex, into a newly allocated array. The caller is
- * responsible for freeing the allocated data. Returns an ERR_PTR upon failure.
+ * responsible for freeing the allocated data. Returns NULL upon failure.
  */
 static struct elf_phdr *load_elf_phdrs(const struct elfhdr *elf_ex,
 				       struct file *elf_file)

Original file line number	Diff line number	Diff line change
`@@ -456,7 +456,7 @@ static unsigned long maximum_alignment(struct elf_phdr *cmds, int nr)`
`456`	`456`	`*`
`457`	`457`	`* Loads ELF program headers from the binary file elf_file, which has the ELF`
`458`	`458`	`* header pointed to by elf_ex, into a newly allocated array. The caller is`
`459`		`- * responsible for freeing the allocated data. Returns an ERR_PTR upon failure.`
	`459`	`+ * responsible for freeing the allocated data. Returns NULL upon failure.`
`460`	`460`	`*/`
`461`	`461`	`static struct elf_phdr load_elf_phdrs(const struct elfhdr elf_ex,`
`462`	`462`	`struct file *elf_file)`