phy: stm32: fix a refcount leak in stm32_usbphyc_pll_enable()

Dan Carpenter · vinodkoul · commit cfc826c88a79 · 2022-01-27T11:04:40.000+05:30
This error path needs to decrement "usbphyc->n_pll_cons.counter" before returning. Fixes: 5b1af71 ("phy: stm32: rework PLL Lock detection") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/20220112111724.GB3019@kili Signed-off-by: Vinod Koul <vkoul@kernel.org>
diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
@@ -304,7 +304,7 @@ static int stm32_usbphyc_pll_enable(struct stm32_usbphyc *usbphyc)
 
 		ret = __stm32_usbphyc_pll_disable(usbphyc);
 		if (ret)
-			return ret;
+			goto dec_n_pll_cons;
 	}
 
 	ret = stm32_usbphyc_regulators_enable(usbphyc);

Original file line number	Diff line number	Diff line change
`@@ -304,7 +304,7 @@ static int stm32_usbphyc_pll_enable(struct stm32_usbphyc *usbphyc)`
`304`	`304`
`305`	`305`	`ret = __stm32_usbphyc_pll_disable(usbphyc);`
`306`	`306`	`if (ret)`
`307`		`- return ret;`
	`307`	`+ goto dec_n_pll_cons;`
`308`	`308`	`}`
`309`	`309`
`310`	`310`	`ret = stm32_usbphyc_regulators_enable(usbphyc);`