media: staging: sun6i-isp: Remove redundant printk

ribalda · mchehab · commit cfffeef587e3 · 2024-05-03T11:07:33.000+01:00
platform_get_irq() already prints an error for us. Found by cocci: drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c:389:2-9: line 389 is redundant because platform_get_irq() already prints an error Link: https://lore.kernel.org/linux-media/20240429-fix-cocci-v3-7-3c4865f5a4b0@chromium.org Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c
@@ -386,8 +386,7 @@ static int sun6i_isp_resources_setup(struct sun6i_isp_device *isp_dev,
 
 	irq = platform_get_irq(platform_dev, 0);
 	if (irq < 0) {
-		dev_err(dev, "failed to get interrupt\n");
-		ret = -ENXIO;
+		ret = irq;
 		goto error_clock_rate_exclusive;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -386,8 +386,7 @@ static int sun6i_isp_resources_setup(struct sun6i_isp_device *isp_dev,`
`386`	`386`
`387`	`387`	`irq = platform_get_irq(platform_dev, 0);`
`388`	`388`	`if (irq < 0) {`
`389`		`- dev_err(dev, "failed to get interrupt\n");`
`390`		`- ret = -ENXIO;`
	`389`	`+ ret = irq;`
`391`	`390`	`goto error_clock_rate_exclusive;`
`392`	`391`	`}`
`393`	`392`