Skip to content

Commit d0031e6

Browse files
Codrin Ciubotariubebarino
authored andcommitted
clk: at91: generated: consider range when calculating best rate
clk_generated_best_diff() helps in finding the parent and the divisor to compute a rate closest to the required one. However, it doesn't take into account the request's range for the new rate. Make sure the new rate is within the required range. Fixes: 8a8f4bf ("clk: at91: clk-generated: create function to find best_diff") Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> Link: https://lore.kernel.org/r/20220413071318.244912-1-codrin.ciubotariu@microchip.com Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 60d9f05 commit d0031e6

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

drivers/clk/at91/clk-generated.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,10 @@ static void clk_generated_best_diff(struct clk_rate_request *req,
117117
tmp_rate = parent_rate;
118118
else
119119
tmp_rate = parent_rate / div;
120+
121+
if (tmp_rate < req->min_rate || tmp_rate > req->max_rate)
122+
return;
123+
120124
tmp_diff = abs(req->rate - tmp_rate);
121125

122126
if (*best_diff < 0 || *best_diff >= tmp_diff) {

0 commit comments

Comments
 (0)