Skip to content

Commit d06bf78

Browse files
mowteamPeter Zijlstra
authored andcommitted
perf: Fix refcount warning on event->mmap_count increment
When calling refcount_inc(&event->mmap_count) inside perf_mmap_rb(), the following warning is triggered: refcount_t: addition on 0; use-after-free. WARNING: lib/refcount.c:25 PoC: struct perf_event_attr attr = {0}; int fd = syscall(__NR_perf_event_open, &attr, 0, -1, -1, 0); mmap(NULL, 0x3000, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); int victim = syscall(__NR_perf_event_open, &attr, 0, -1, fd, PERF_FLAG_FD_OUTPUT); mmap(NULL, 0x3000, PROT_READ | PROT_WRITE, MAP_SHARED, victim, 0); This occurs when creating a group member event with the flag PERF_FLAG_FD_OUTPUT. The group leader should be mmap-ed and then mmap-ing the event triggers the warning. Since the event has copied the output_event in perf_event_set_output(), event->rb is set. As a result, perf_mmap_rb() calls refcount_inc(&event->mmap_count) when event->mmap_count = 0. Disallow the case when event->mmap_count = 0. This also prevents two events from updating the same user_page. Fixes: 448f97f ("perf: Convert mmap() refcounts to refcount_t") Suggested-by: Peter Zijlstra <peterz@infradead.org> Signed-off-by: Will Rosenberg <whrosenb@asu.edu> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://patch.msgid.link/20260119184956.801238-1-whrosenb@asu.edu
1 parent 24d479d commit d06bf78

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

kernel/events/core.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6997,6 +6997,15 @@ static int perf_mmap_rb(struct vm_area_struct *vma, struct perf_event *event,
69976997
if (data_page_nr(event->rb) != nr_pages)
69986998
return -EINVAL;
69996999

7000+
/*
7001+
* If this event doesn't have mmap_count, we're attempting to
7002+
* create an alias of another event's mmap(); this would mean
7003+
* both events will end up scribbling the same user_page;
7004+
* which makes no sense.
7005+
*/
7006+
if (!refcount_read(&event->mmap_count))
7007+
return -EBUSY;
7008+
70007009
if (refcount_inc_not_zero(&event->rb->mmap_count)) {
70017010
/*
70027011
* Success -- managed to mmap() the same buffer

0 commit comments

Comments
 (0)