virtio_input: use virtqueue_add_inbuf_cache_clean for events

mstsirkin · mstsirkin · commit d08fda2cf2e6 · 2026-01-08T09:54:27.000-05:00
The evts array contains 64 small (8-byte) input events that share
cachelines with each other. When CONFIG_DMA_API_DEBUG is enabled,
this can trigger warnings about overlapping DMA mappings within
the same cacheline.

Previous patch isolated the array in its own cachelines,
so the warnings are now spurious.

Use virtqueue_add_inbuf_cache_clean() to indicate that the CPU does not
write into these cache lines, suppressing these warnings.

Message-ID: &lt;4c885b4046323f68cf5cadc7fbfb00216b11dd20.1767601130.git.mst@redhat.com&gt;
Signed-off-by: Michael S. Tsirkin &lt;mst@redhat.com&gt;
diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c
@@ -30,7 +30,7 @@ static void virtinput_queue_evtbuf(struct virtio_input *vi,
 	struct scatterlist sg[1];
 
 	sg_init_one(sg, evtbuf, sizeof(*evtbuf));
-	virtqueue_add_inbuf(vi->evt, sg, 1, evtbuf, GFP_ATOMIC);
+	virtqueue_add_inbuf_cache_clean(vi->evt, sg, 1, evtbuf, GFP_ATOMIC);
 }
 
 static void virtinput_recv_events(struct virtqueue *vq)

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ static void virtinput_queue_evtbuf(struct virtio_input *vi,`
`30`	`30`	`struct scatterlist sg[1];`
`31`	`31`
`32`	`32`	`sg_init_one(sg, evtbuf, sizeof(*evtbuf));`
`33`		`- virtqueue_add_inbuf(vi->evt, sg, 1, evtbuf, GFP_ATOMIC);`
	`33`	`+ virtqueue_add_inbuf_cache_clean(vi->evt, sg, 1, evtbuf, GFP_ATOMIC);`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`static void virtinput_recv_events(struct virtqueue *vq)`