quota: correct error number in free_dqentry()

zhangyi089 · jankara · commit d0e36a62bd4c · 2021-10-11T10:57:04.000+02:00
Fix the error path in free_dqentry(), pass out the error number if the block to free is not correct. Fixes: 1ccd14b ("quota: Split off quota tree handling into a separate file") Link: https://lore.kernel.org/r/20211008093821.1001186-3-yi.zhang@huawei.com Signed-off-by: Zhang Yi <yi.zhang@huawei.com> Cc: stable@kernel.org Signed-off-by: Jan Kara <jack@suse.cz>
diff --git a/fs/quota/quota_tree.c b/fs/quota/quota_tree.c
@@ -414,6 +414,7 @@ static int free_dqentry(struct qtree_mem_dqinfo *info, struct dquot *dquot,
 		quota_error(dquot->dq_sb, "Quota structure has offset to "
 			"other block (%u) than it should (%u)", blk,
 			(uint)(dquot->dq_off >> info->dqi_blocksize_bits));
+		ret = -EIO;
 		goto out_buf;
 	}
 	ret = read_blk(info, blk, buf);

Original file line number	Diff line number	Diff line change
`@@ -414,6 +414,7 @@ static int free_dqentry(struct qtree_mem_dqinfo info, struct dquot dquot,`
`414`	`414`	`quota_error(dquot->dq_sb, "Quota structure has offset to "`
`415`	`415`	`"other block (%u) than it should (%u)", blk,`
`416`	`416`	`(uint)(dquot->dq_off >> info->dqi_blocksize_bits));`
	`417`	`+ ret = -EIO;`
`417`	`418`	`goto out_buf;`
`418`	`419`	`}`
`419`	`420`	`ret = read_blk(info, blk, buf);`